Allow multiple anonymous imports if className is only in one of them. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the className is present in multiple anonymous imports throw an error saying that you must use a named import for one of them.
|
Concept ACK. I like the added flexibility. |
|
Would be Okay with this if it is guarded by a setting. Not a behaviour I would encourage otherwise. Please add tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the current readme:
This PR allows multiple anonymous css imports. It is only a problem if you use a styleName which is present in multiple anonymous imports, in which case an error is thrown:
Let me know what you think and I can update the tests and docs.