Merge gardener/gardener-extensions@v1.6.0 #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing because CI/CD is not yet adapted. See https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-rc/jobs/rc-head-update-job/builds/14 for a successful build. |
timebertt
requested changes
Apr 6, 2020
ialidzhikov
requested changes
Apr 6, 2020
ialidzhikov
reviewed
Apr 6, 2020
timuthy
requested changes
Apr 6, 2020
|
Thanks for your reviews, please check it again! :) |
timebertt
previously approved these changes
Apr 6, 2020
timuthy
approved these changes
Apr 7, 2020
timebertt
approved these changes
Apr 7, 2020
|
Thanks colleagues, will merge and adapt the pipeline definition now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR merges the gardener/gardener-extensions repository into gardener/gardener, based on v1.6.0.
After the extension repository split the indirection with gardener/gardener-extensions does not have any benefit anymore. Instead, it makes it even harder for extensions to keep up to date.
As the extensions contract is maintained in g/g it also makes sense to maintain the extensions library in g/g now.
Which issue(s) this PR fixes:
Fixes #1708
Fixes #1660
Special notes for your reviewer:
hackscriptsverifystep in the CI build - it does extended checks and tests the code + outputs coverageverifystep is not done as part of theDockerfiledue to Concourse limitations with building multi-stage Dockerfiles.Release note: