Skip to content

[pull] main from bazel-contrib:main #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

[pull] main from bazel-contrib:main #292

merged 2 commits into from
May 29, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented May 29, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

rickeylev added 2 commits May 29, 2025 13:21
The redirect was going to a non-existent URL when viewed on the deployed
docs.

This was happening because the absolute paths `/api/whatever` don't
exist in the deployed
site -- it's actually `/en/latest/api/whatever`. This went unnoticed
because it works
locally (where there is no /en/latest prefix).

To fix, use a relative url (relative urls are relative to the path that
is redirected from)
This basically allows using any python-build-standalone archive and
using it
if custom flags are set. This is done through the
`single_version_platform_override()`
API, because such archives are inherently version and platform specific.

Key changes:
* The `platform` arg can be any value (mostly; it ends up in repo names)
* Added `target_compatible_with` and `target_settings` args, which
become the
  settings used on the generated toolchain() definition.

The platform settings are version specific, i.e. the key
`(python_version, platform)`
is what maps to the TCW/TS values.

If an existing platform is used, it'll override the defaults that
normally come
from the PLATFORMS global for the particular version. If a new platform
is used,
it creates a new platform entry with those settings.

Along the way:
* Added various docs about internal variables so they're easier to grok
at a glance.

Work towards #2081
@pull pull bot added the ⤵️ pull label May 29, 2025
@pull pull bot merged commit d60cee2 into garymm:main May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant