Skip to content

feat: support to specify custom domain to apigateway #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

Blankll
Copy link
Member

@Blankll Blankll commented Feb 23, 2025

feat: support to specify custom domain to apigateway
.

Refs: #49

Signed-off-by: seven <zilisheng1996@gmail.com>
Signed-off-by: seven <zilisheng1996@gmail.com>
@Blankll Blankll marked this pull request as ready for review February 24, 2025 14:09
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (172f090) to head (5b3e621).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/stack/rosStack/event.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   87.24%   87.29%   +0.04%     
==========================================
  Files          49       50       +1     
  Lines         643      661      +18     
  Branches      104      109       +5     
==========================================
+ Hits          561      577      +16     
- Misses         58       59       +1     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: seven <zilisheng1996@gmail.com>
@Blankll Blankll merged commit 93de6e2 into master Feb 24, 2025
2 checks passed
@Blankll Blankll deleted the feat/agw-domain branch February 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant