Skip to content

The project doesn't need to use Testbench BrowserKit #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crynobone opened this issue Feb 10, 2018 · 1 comment
Closed

The project doesn't need to use Testbench BrowserKit #121

crynobone opened this issue Feb 10, 2018 · 1 comment
Assignees
@mikebronner

Comments

@crynobone
Copy link

From what I see in the tests folder, you don't actually need Testbench BrowserKit, FeatureTestCase should just extends Orchestra\Testbench\TestCase.

Testbench

It's loads Laravel apps and able you to run artisan commands, migrations, basic routing from within your tests.

Testbench BrowserKit

It extends Testbench an allow you to interact with the view using CSS selectors (interacting with form, button, link etc) but without JavaScript.

Testbench Dusk

It extends Testbench an allow you to interact with the view using CSS selectors (interacting with form, button, link etc) with JavaScript (using Chrome browser).
@mikebronner
Copy link
Member

mikebronner commented Feb 10, 2018 •
edited
Loading

Right, I know they aren't necessary. My dev workflow includes this encompassing setup. I have moved to this for all my packages, and like to keep the same workflow for all packages for maintenance and ease of use. :)

But you're right, the existing tests don't utilize any browser actions.

@mikebronner mikebronner self-assigned this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebronner mikebronner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crynobone @mikebronner