Skip to content

PHPDoc is wrong on \Geocoder\Laravel\ProviderAndDumperAggregator::get #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexgmin opened this issue May 12, 2017 · 5 comments
Closed

PHPDoc is wrong on \Geocoder\Laravel\ProviderAndDumperAggregator::get #78

alexgmin opened this issue May 12, 2017 · 5 comments
Assignees
@mikebronner
Labels
bug

Comments

@alexgmin
Copy link
Contributor

Issue Description

image

Also, instead of

    /**
     * @var AddressCollection
     */

it should be

    /**
     * @var \Geocoder\Model\AddressCollection
     */

image

image
@Nyholm
Copy link
Member

Nyholm commented May 12, 2017

You are correct, that is missing.

We should add use Geocoder\Model\AddressCollection; at the top of the file. Could you add a PR?

@alexgmin
Copy link
Contributor Author

I'll have to setup the project at home, and also, this would be my first PR, but sure.

@Nyholm
Copy link
Member

Nyholm commented May 12, 2017

That would be great. Im looking forward to review it.

@mikebronner mikebronner self-assigned this May 12, 2017
@mikebronner
Copy link
Member

@alexgmin Thanks for reporting that. Should be fixed now. Let us know if you find anything else. :)

@mikebronner
Copy link
Member

@Nyholm thanks for responding so quickly to the issue. :) (Small things like this I don't mind fixing without PRs.)

@alexgmin alexgmin mentioned this issue May 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebronner mikebronner

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nyholm @mikebronner @alexgmin