Update to Geocoder v3 and register named providers #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only chain provider registration
|
@shtricul Thank you. It looks good. Can you update the doc as well please? :) |
|
So...has this change been held back for over a half year just for documentation? If it's fully functional, any chance of getting it merged in? Or maybe start a release branch to pull in other updates as well and encourage doc updates before merging to master and tagging a release? cc @toin0u @shtricul |
|
Thanks for this PR ... we are implememting an update to Geocoder v3.3.x and should have it out shortly. Closing this PR for now, as things have changed somewhat and we have another similar PR in the works. Thanks for your efforts though, please continue submitting PRs if you see something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs to update Geocoder version in composer.json.
Geocoder::using('provider_name').