Alias IoC key to Geocoder class for DI #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When using this approach I receive an error
What is the correct way to register providers when using DI? public function __construct(\Geocoder\Geocoder $geocoder)
{
var_dump($geocoder->geocode('some address'));
}Note when using the facade as outlined in the readme, the geocode works as expected. |
|
This would not be the correct way to use it. The Facade actually contains a wired up instance with adapter and provider already set. Insttead of using DI here, perhaps using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general I prefer injecting my dependencies when possible, instead of using facades.
Currently I can't inject
Geocoder\Geocoderinto my controller (or anywhere else) because Laravel would inject a new instance, not the one that your service provider wires up.This pull request modified the service provider to alias
geocodertoGeocoder\Geocoderand makes it DI friendly. This way I can:Note I'm following the pattern from the AwsLaravel package:
https://github.com/aws/aws-sdk-php-laravel/blob/master/src/AwsServiceProvider.php#L53