Skip to content

test(nextjs): Test for client trace propagation with Turbopack #14059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2024
Merged

test(nextjs): Test for client trace propagation with Turbopack #14059

merged 4 commits into from
Oct 28, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Oct 23, 2024 •
edited
Loading

Resolves #13656

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
240 1 239 8
View the top 1 failed tests by shortest run time 
pages-router/client-trace-propagation.test.ts Should propagate traces from server to client in pages router
Stack Traces | 30s run time 
client-trace-propagation.test.ts:5:5 Should propagate traces from server to client in pages router

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@lforst lforst mentioned this pull request Oct 23, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.12 KB - -
@sentry/browser (incl. Tracing, Replay) 71.86 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.26 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.21 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.99 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.82 KB - -
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 38.09 KB - -
@sentry/vue 26.91 KB - -
@sentry/vue (incl. Tracing) 37.02 KB - -
@sentry/svelte 22.87 KB - -
CDN Bundle 24.11 KB - -
CDN Bundle (incl. Tracing) 36.96 KB - -
CDN Bundle (incl. Tracing, Replay) 71.65 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.99 KB - -
CDN Bundle - uncompressed 70.7 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.73 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.24 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.46 KB - -
@sentry/nextjs (client) 38.17 KB +0.3% +115 B 🔺
@sentry/sveltekit (client) 35.74 KB - -
@sentry/node 124.96 KB -0.16% -200 B 🔽
@sentry/node - without tracing 94.01 KB -0.26% -247 B 🔽
@sentry/aws-serverless 103.62 KB -0.19% -200 B 🔽

View base workflow run

@lforst lforst marked this pull request as ready for review October 24, 2024 13:39
@lforst lforst requested a review from chargome October 24, 2024 13:40
@lforst lforst merged commit ff8e780 into develop Oct 28, 2024
122 checks passed
@lforst lforst deleted the lforst-nextjs-test-turbo-client-trace-propagation branch October 28, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next.js: Pick up clientTraceMetadata in pages router instrumentation
2 participants
@lforst @chargome