Skip to content

ref: Provide originalException in minimal calls as well #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

ref: Provide originalException in minimal calls as well #1509

merged 1 commit into from
Sep 5, 2018

Conversation

kamilogorek
Copy link
Contributor

I do this on captureMessage as well, as sometimes people pass malformed data to those calls and it's totally fine to let them see it.

@kamilogorek kamilogorek requested a review from HazAT September 5, 2018 08:51
@codecov-io
Copy link

codecov-io commented Sep 5, 2018 •
edited
Loading

Codecov Report

Merging #1509 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1509   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files          44       44           
  Lines        1330     1330           
  Branches      252      252           
=======================================
  Hits          972      972           
  Misses        350      350           
  Partials        8        8
Impacted Files Coverage Δ
packages/minimal/src/index.ts 95.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b629e...1939b83. Read the comment docs.

@kamilogorek kamilogorek merged commit 0b7e024 into master Sep 5, 2018
@kamilogorek kamilogorek deleted the minimal-original-exception-hint branch September 5, 2018 09:26
Turbo87 added a commit to Turbo87/sentry-javascript that referenced this pull request May 7, 2019
@Turbo87
integrations/ember: Pass originalException to captureException() …
3068922 
…calls

This makes `originalException` available to the `beforeSend()` hook.

see getsentry#1509
@Turbo87 Turbo87 mentioned this pull request May 7, 2019
Merged
HazAT pushed a commit that referenced this pull request May 8, 2019
@Turbo87 @HazAT
integrations/ember: Pass originalException to captureException() …
bc4cb71 
…calls (#2056)

This makes `originalException` available to the `beforeSend()` hook.

see #1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamilogorek @codecov-io @mitsuhiko @HazAT