ref(nextjs): Prefer esm/index.server.js over CJS version
#16144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esm/index.server.js over CJS versionesm/index.server.js over CJS version
|
Hey @mischnic thanks for opening this PR! To assess priority: Is the current exports declaration blocking you in some way? Could you elaborate a bit more what the specific issue is that this PR solves? Thanks! I started our CI so that we check if our NextJS E2E tests are still passing. Unfortunately, exports changes are always a bit risky. Also gonna ask @chargome to review |
|
Sorry for the short description, this is the fix for #16121 as with this change, importing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes bundlers prefer the ESM version of
index.server.js, for better tree shaking.The ESM versions are already listed first for the edge versions