Skip to content

fix: Fix typos in setTag examples #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

fix: Fix typos in setTag examples #1678

merged 1 commit into from
Oct 24, 2018

Conversation

lobsterkatie
Copy link
Member

As seen here, the method is called setTag, not setTags.

Confirmed by @HazAT .

@getsentry-bot
Copy link
Contributor

Warnings
⚠️

Please add a changelog entry for your changes.

Messages
📖

✅ TSLint passed

📖

@sentry/browser gzip'ed minified size: 23.3848 kB

Generated by 🚫 dangerJS

@lobsterkatie
Copy link
Member Author

lobsterkatie commented Oct 23, 2018

Hmmm - travis is failing here: https://travis-ci.com/getsentry/sentry-javascript/jobs/153666457

Not sure why. (Looks like a timeout, so I tried again, but it failed again.)

EDIT: Ran it one more time, and now it's failing for different reasons, that didn't make it fail before. What??

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, they are flakey sometimes, tests ran fine before.
Thanks for the fix 👍

@HazAT HazAT merged commit 839326f into master Oct 24, 2018
@HazAT HazAT deleted the kmclb-fix-settags-typo branch October 24, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants