Enable additional context to be sent as part of the error via the request object. #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can already achieve this behavior with the code below after your function sentryExtraContextMiddleware(req, res, next) {
Sentry.getCurrentHub().configureScope(scope =>
scope.addEventProcessor(async event => {
if (Object.prototype.toString.call(req.extraContext) === '[object Object]') {
event.extra = {
...event.extra,
...req.extraContext,
};
}
return event;
}),
);
next();
}
app.use(sentryExtraContextMiddleware);We don't want to add custom attributes to the request itself, as we'd have to keep documentation in-sync, as well as provide this feature for every framework. |
|
@kamilogorek That is exactly what I needed. Thanks! |
|
Anytime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).I'm not entirely sure whether this should be tested or not. It's a relatively trivial change for some behavior that could potentially cause some significant issues (if a user passed a function as part of the object and all that).