Feat/migration docs #1959
Merged
Feat/migration docs #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wong2
reviewed
Mar 27, 2019
|
|
||
| ```js | ||
| import * as Sentry from '@sentry/browser'; | ||
| import * as Integrations from '@sentry/integrations'; |
There was a problem hiding this comment.
I tried 5.0.0-rc.3 with node
> require('@sentry/integrations')
{ Error: Cannot find module '@sentry/integrations'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)
at Function.Module._load (internal/modules/cjs/loader.js:506:25)
at Module.require (internal/modules/cjs/loader.js:636:17)
at require (internal/modules/cjs/helpers.js:20:18) code: 'MODULE_NOT_FOUND' }
There was a problem hiding this comment.
@wong2 Yeah, I changed it in this PR to expose index.js in package.json
This will work with rc.4 sorry
There was a problem hiding this comment.
@HazAT oh I missed that, thanks a lot
|
@mitsuhiko this also fixed the integration array in sdk info |
kamilogorek
suggested changes
Mar 27, 2019
Co-Authored-By: HazAT <daniel.griesser.86@gmail.com>
kamilogorek
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure we upload and expose
@sentry/integrationsthe right way.Also, we added
integrationstosdkin the event.