Skip to content

fix: Node do not require window to build #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2019
Merged

fix: Node do not require window to build #2007

merged 3 commits into from
Apr 9, 2019

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Apr 9, 2019

Fixes #2002

Moved htmlTreeAsString to browser since we only use it there, we are also able to minify it now.
And removed typehit for getGlobalObject since it's any most of the time.

@HazAT HazAT self-assigned this Apr 9, 2019
@HazAT HazAT requested a review from kamilogorek as a code owner April 9, 2019 11:33
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Apr 9, 2019 •
edited
Loading

Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 15.5859 kB) (ES6: 14.251 kB)

Generated by 🚫 dangerJS against 7e8f27c

@kamilogorek
Copy link
Contributor

Are we sure we want any for browser frameworks integrations?

@HazAT
Copy link
Member Author

HazAT commented Apr 9, 2019 •
edited
Loading

It was any before so I guess 🤷‍♂️
Window doesn't work since there is no angular on window for example.

@kamilogorek
Copy link
Contributor

True that.

@HazAT HazAT merged commit f68b3ec into master Apr 9, 2019
@HazAT HazAT deleted the fix/node-build branch April 9, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HazAT @getsentry-bot @kamilogorek