Allow sentry to work with v8 on react-native #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kamilogorek merged 2 commits into getsentry:master from axsy-dev:master

Jan 28, 2020

Contributor

gillpeacegood commented Jan 28, 2020

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).


          Allow sentry to work with v8 on react-native

96e77be

gillpeacegood requested a review from kamilogorek as a code owner

January 28, 2020 11:43

Contributor

kamilogorek commented Jan 28, 2020

Thanks for the PR. Can you also add a test for this case here? https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/test/unit/tracekit/custom.test.ts


          Add a unit test for react-native-v8

341ff9b

kamilogorek merged commit 9a54650 into getsentry:master

Contributor

kamilogorek commented Jan 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet