ref: Restore node 6 support due to yarn engine checks, add performance.now fallback #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
Feb 28, 2020
|
awesome, thanks @kamilogorek :) |
rhcarvalho
reviewed
Feb 28, 2020
|
|
||
| const performanceFallback: Pick<Performance, 'now'> = { | ||
| now(): number { | ||
| return INITIAL_TIME - Date.now(); |
There was a problem hiding this comment.
I think storing the initial time is unnecessary.
The point of using performance.now is to compute durations t1-t0; it doesn't matter to subtract yet INITIAL_TIME. And as a fallback it is limited anyway, since it is has no guarantee on being monotonic, unlike the real performance.now.
There was a problem hiding this comment.
performance.now returns a delta from start till now. We need a fallback to do the same, in behavior sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2455 (comment)