Skip to content

feat: Require use of flag to send envelopes #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

feat: Require use of flag to send envelopes #2594

merged 1 commit into from
May 15, 2020

Conversation

rhcarvalho
Copy link
Contributor

This gives us an easy kill-switch if we decide to revert back to the
store endpoint. Sending envelopes becomes opt-in.

Usage:

Sentry.init({
  dsn: '...',
  integrations: [new Sentry.Integrations.Tracing()],
  tracesSampleRate: 1,
  _experiments: { useEnvelope: true },
});

@rhcarvalho rhcarvalho requested a review from kamilogorek as a code owner May 15, 2020 09:29
@rhcarvalho
feat: Require use of flag to send envelopes
9c0aaa7 
This gives us an easy kill-switch if we decide to revert back to the
store endpoint. Sending envelopes becomes opt-in.

Usage:

Sentry.init({
  dsn: '...',
  integrations: [new Sentry.Integrations.Tracing()],
  tracesSampleRate: 1,
  _experiments: { useEnvelope: true },
});
@rhcarvalho rhcarvalho force-pushed the envelope-kill-switch branch from 06c0195 to 9c0aaa7 Compare May 15, 2020 09:32
@getsentry-bot
Copy link
Contributor

getsentry-bot commented May 15, 2020 •
edited
Loading

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.1436 kB) (ES6: 16.1758 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 9c0aaa7

HazAT
HazAT requested changes May 15, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, let's wait until we have a fix.

HazAT
HazAT approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can proceed with 5.16.0

@rhcarvalho
Copy link
Contributor Author

Broken BrowserStack https://travis-ci.com/github/getsentry/sentry-javascript/jobs/334482623

image

Not clear to me what the error was. I see things like

IE 10.0.0 (Windows 8.0.0) ERROR: 'This browser lacks typed array (Uint8Array) support which is required by `buffer` v5.x. Use `buffer` v4.x if you require old browser support.'

and hung up connections.

Will try a re-run.

@rhcarvalho
Copy link
Contributor Author

BS is green, re-running Deploy stage and wondering whether we should run it only in master/release branches.

@rhcarvalho rhcarvalho merged commit 0d9725a into master May 15, 2020
@rhcarvalho rhcarvalho deleted the envelope-kill-switch branch May 15, 2020 14:21
HazAT added a commit that referenced this pull request May 25, 2020
@HazAT
Revert "feat: Require use of flag to send envelopes (#2594)"
ea9bd46 
This reverts commit 0d9725a.
HazAT added a commit that referenced this pull request May 27, 2020
@HazAT
Revert "feat: Require use of flag to send envelopes (#2594)" (#2612)
f1f0924 
This reverts commit 0d9725a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhcarvalho @getsentry-bot @HazAT @kamilogorek