Skip to content

feat(integrations): Call toJSON of originalException to extract more data #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 11, 2021
Merged

feat(integrations): Call toJSON of originalException to extract more data #4038

merged 7 commits into from
Oct 11, 2021

Conversation

kamilogorek
Copy link
Contributor

Fixes #4022

@kamilogorek kamilogorek requested review from a team, AbhiPrasad and iker-barriocanal and removed request for a team October 8, 2021 10:32
kamilogorek
kamilogorek commented Oct 8, 2021
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.33 KB (0%)
@sentry/browser - Webpack 23.31 KB (0%)
@sentry/react - Webpack 23.34 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.79 KB (0%)

iker-barriocanal
iker-barriocanal reviewed Oct 8, 2021
View reviewed changes
iker-barriocanal
iker-barriocanal reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a test where toJSON overwrites a property.

iker-barriocanal
iker-barriocanal reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd test that toJSON is able to rewrite native props, different from having priority over the directly assigned ones.

@kamilogorek
Copy link
Contributor Author

@iker-barriocanal added one remaining test

@kamilogorek kamilogorek force-pushed the tojson-extra-error-data branch from 66f28a0 to 0cc9fdc Compare October 11, 2021 10:27
iker-barriocanal
iker-barriocanal approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kamilogorek kamilogorek merged commit 884dc89 into master Oct 11, 2021
@kamilogorek kamilogorek deleted the tojson-extra-error-data branch October 11, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad AbhiPrasad was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExtraErrorData + AxiosError don't work
2 participants
@kamilogorek @iker-barriocanal