Skip to content

chore(eslint): Add eslint checks to eslint plugin #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

chore(eslint): Add eslint checks to eslint plugin #4537

merged 1 commit into from
Feb 11, 2022

Conversation

AbhiPrasad
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (164c09c) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.77 KB 19.77 KB +0.01% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63.17 KB 63.18 KB +0.01% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.51 KB 18.51 KB +0.01% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.8 KB 56.8 KB +0.01% 🔺
@sentry/browser - Webpack (gzipped + minified) 22.21 KB 22.21 KB 0%
@sentry/browser - Webpack (minified) 76.02 KB 76.02 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.31 KB 46.31 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.32 KB 28.33 KB +0.02% 🔺

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lobsterkatie and removed request for a team February 10, 2022 19:41
@lobsterkatie lobsterkatie changed the title chore(eslint): Add eslint to eslint plugin chore(eslint): Add eslint checks to eslint plugin Feb 11, 2022
lobsterkatie
lobsterkatie approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

I hope you don't mind - I edited the title slightly for clarity.

(P.S., seriously? Of all the places to be missing eslint! How did we not have this all along, LOL?)

@AbhiPrasad AbhiPrasad merged commit 487945f into master Feb 11, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-eslint-plugin-sdk-eslint branch February 11, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lobsterkatie