Skip to content

ref(build): Reenable lambda layer release in craft #5207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 7, 2022
Merged

ref(build): Reenable lambda layer release in craft #5207

merged 14 commits into from
Jul 7, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jun 3, 2022 •
edited
Loading

This is the PR for releasing "Serverless V2":

  • Reactivating the deployment of the Lambda Layer when a new Version of the SDK is deployed
  • Updated the helper script for deploying the local code base as dev Lambda layer to use relay for the Lambda Extension.

This PR will be merged when the new relay is released, which happens on June 15th.
Until then, this will stay in "draft" mode.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.34 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 59.86 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.94 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.78 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.71 KB (-0.02% 🔽)
@sentry/browser - Webpack (minified) 64.15 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.73 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.9 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.69 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.94 KB (-0.01% 🔽)

lobsterkatie
lobsterkatie previously approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only suggestion/request would be to add a few comments to the script, as not all JS devs are necessarily super fluent in bash.

@lobsterkatie lobsterkatie changed the title Antonpirker feature serverless v2 ref(build): Reenable lambda layer release in craft Jun 3, 2022
@antonpirker
Copy link
Member Author

Thanks for review @lobsterkatie
I added some comments to clarify the bash script.

@antonpirker antonpirker marked this pull request as ready for review June 20, 2022 09:23
frankleng
frankleng reviewed Jun 30, 2022
View reviewed changes
frankleng
frankleng reviewed Jun 30, 2022
View reviewed changes
@smeubank
Copy link
Member

smeubank commented Jun 30, 2022 •
edited
Loading

@Lms24 can you help me keep an eye on this that it get's merged and shipped?

edit: wrong Lukas tagged 😆

lforst
lforst previously requested changes Jul 4, 2022
View reviewed changes
@lforst lforst dismissed stale reviews from lobsterkatie and themself July 4, 2022 16:27

Stale

Lms24
Lms24 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@lforst lforst merged commit 2bc61b0 into master Jul 7, 2022
@lforst lforst deleted the antonpirker-feature-serverless-v2 branch July 7, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankleng frankleng frankleng left review comments

@lforst lforst lforst left review comments

@Lms24 Lms24 Lms24 approved these changes

@lobsterkatie lobsterkatie lobsterkatie left review comments

Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@antonpirker @smeubank @frankleng @lforst @Lms24 @lobsterkatie