Skip to content

Get rid of setup.cfg by moving the only option to setup.py #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Get rid of setup.cfg by moving the only option to setup.py #1040

merged 2 commits into from
Mar 4, 2021

Conversation

hynek
Copy link
Contributor

@hynek hynek commented Mar 4, 2021

🎉

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't know you can do that!

@hynek
Copy link
Contributor Author

hynek commented Mar 4, 2021

Python packaging is a land full of mysteries. ;)

I've been told it once by the maintainers in connection with my PyPI blog post.

@untitaker
Copy link
Member

Do you know by chance when this feature was introduced? I mean, seems to run fine on last pip for 2.7, but we have people running on 2.6.

@hynek
Copy link
Contributor Author

hynek commented Mar 4, 2021

I don't think this is a pip feature but a setuptools/wheel one.

Assuming it's a recent-ish features (which I don't think), it would only affect people who insist on building their sdists with ancient build chains into wheels.

@untitaker
Copy link
Member

Fair enough.

@untitaker untitaker merged commit de1ceb8 into getsentry:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants