fix: Fix concurrency issues in sanic #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 66.92% 66.93% +0.01%
==========================================
Files 25 25
Lines 2473 2474 +1
Branches 354 354
==========================================
+ Hits 1655 1656 +1
Misses 685 685
Partials 133 133
Continue to review full report at Codecov.
|
untitaker
commented
Oct 12, 2018
|
|
||
| with hub.push_scope() as scope: | ||
| with Hub(hub) as hub: |
There was a problem hiding this comment.
I couldn't think of a testcase that would show copy_context is necessary.
There was a problem hiding this comment.
Ah, I assume sanic already has one context per request
mitsuhiko
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #120