Skip to content

fix: Dont crash on composed psycopg2 queries #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

untitaker
Copy link
Member

Fix #201

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #202 into master will increase coverage by 0.13%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   80.52%   80.65%   +0.13%     
==========================================
  Files          31       31              
  Lines        2608     2611       +3     
  Branches      442      444       +2     
==========================================
+ Hits         2100     2106       +6     
+ Misses        328      327       -1     
+ Partials      180      178       -2
Impacted Files Coverage Δ
sentry_sdk/integrations/django/__init__.py 84.44% <77.77%> (+0.26%) ⬆️
sentry_sdk/utils.py 81.48% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba8d4f...aa2040c. Read the comment docs.

@untitaker
Copy link
Member Author

#203 is better

@untitaker untitaker closed this Dec 13, 2018
@untitaker untitaker deleted the fix/psycopg2 branch December 19, 2018 10:38
untitaker pushed a commit that referenced this pull request Mar 21, 2019
* Use cursor.mogrify when available instead of trying to reimplement sql formatting

* fix: Port changes from #202

* fix: Formatting

* adds test for psycopg2 methods

* use old style django postgres backend

* have travis install test database as well for older versions of django

* fix: Avoid bytestrings, refactor postgres setup

* fix: Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants