Skip to content

Rework proxy selection #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Conversation

crepererum
Copy link
Contributor

Fixes #308
Fixes #178

@untitaker
Copy link
Member

Thanks for this! Since we try to have this interface aligned across SDKs I'll discuss this with the other SDK maintainers first.

@crepererum
Copy link
Contributor Author

@untitaker are there any updates on that?

@untitaker
Copy link
Member

@crepererum I forgot to start the discussion at the last meeting, sorry. We have a meeting every monday (so, today again) where I will bring this up, but please note that this is quite low-priority for us and we can't force a decision "at gunpoint".

@untitaker
Copy link
Member

untitaker commented Apr 8, 2019

To be clear, I see two possible versions:

  • init(http_proxy=False, https_proxy=False)

  • init(no_proxy=True)

@untitaker
Copy link
Member

Sorry, we have an update now: Could you use empty string to represent False? We want to port this behavior to other languages and there we can't replicate this type signature.

@crepererum crepererum force-pushed the feature/proxy_false branch from 20950d1 to 22c7d7a Compare April 24, 2019 13:41
@crepererum
Copy link
Contributor Author

Done. Build failure seems unrelated (pip doesn't like pyproject.toml and editable installs)

@untitaker
Copy link
Member

I made a PR: #349

@untitaker untitaker merged commit 78d17d1 into getsentry:master Apr 25, 2019
@untitaker
Copy link
Member

Thanks! I am quite sorry for the dragging response. It's been a few busy weeks.

@untitaker
Copy link
Member

Released 0.7.12 with this fix (soon)

@rmk135
Copy link

rmk135 commented May 14, 2020

Has this been already released to PyPI?

@untitaker
Copy link
Member

@rmk135, yes, 0.7.12 is on pypi. We're on 0.14 right now

@rmk135
Copy link

rmk135 commented May 14, 2020

and it's in 0.14.4 since yesterday, right?

@untitaker
Copy link
Member

this was merged in 0.7.12. 0.7.12 is on pypi since april last year. 0.14.4 contains the same change.

@rmk135
Copy link

rmk135 commented May 14, 2020

Right. Sorry, I got messed up something with something :) Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify proxy fallback behavior Send events without proxy when http_proxy is configured as env variable
3 participants