-
Notifications
You must be signed in to change notification settings - Fork 549
Rework proxy selection #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this! Since we try to have this interface aligned across SDKs I'll discuss this with the other SDK maintainers first. |
@untitaker are there any updates on that? |
@crepererum I forgot to start the discussion at the last meeting, sorry. We have a meeting every monday (so, today again) where I will bring this up, but please note that this is quite low-priority for us and we can't force a decision "at gunpoint". |
To be clear, I see two possible versions:
|
Sorry, we have an update now: Could you use empty string to represent |
20950d1
to
22c7d7a
Compare
Done. Build failure seems unrelated (pip doesn't like pyproject.toml and editable installs) |
I made a PR: #349 |
Thanks! I am quite sorry for the dragging response. It's been a few busy weeks. |
Released 0.7.12 with this fix (soon) |
Has this been already released to PyPI? |
@rmk135, yes, 0.7.12 is on pypi. We're on 0.14 right now |
and it's in |
this was merged in 0.7.12. 0.7.12 is on pypi since april last year. 0.14.4 contains the same change. |
Right. Sorry, I got messed up something with something :) Thanks for the help. |
Fixes #308
Fixes #178