Fix some methods in POTelSpan #3492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5279037 to
e7d1ecb
Compare
❌ 4425 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
e7d1ecb to
93fc2d6
Compare
sentrivana
approved these changes
Sep 3, 2024
Comment on lines
+1270
to
+1271
| if not isinstance(self._otel_span, ReadableSpan): | ||
| return None |
There was a problem hiding this comment.
We can have a decorator at some point that does this, we could reuse that everywhere for this is-recording-span check. Don't have to do it now, just a note for later when we're cleaning stuff up
* Use `ReadableSpan` checks for attribute and parent access (handles the `NonRecordingSpan` case as a result) * deleted methods `continue_from_environ`, `continue_from_headers` and `from_traceparent` from `POTelSpan`, the new interface will not support them, but we might shim them later to not break code from outside the otel stuff * replaced `continue_from_headers` with `continue_trace` in grpc
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
bbb0630 to
545f3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableSpanchecks for attribute and parent access (handles theNonRecordingSpancase as a result)continue_from_environ,continue_from_headersandfrom_traceparentfromPOTelSpan, the new interface will not support them, but we might shim them later to not break code from outside the otel stuffcontinue_from_headerswithcontinue_tracein grpc