Skip to content

fix: Ignore Celery exceptions used for control flow #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2019
Merged

fix: Ignore Celery exceptions used for control flow #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd5a4a
fix: Ignore Celery exceptions used for control flow
untitaker Apr 29, 2019
3cfabcd
fix: Linters
untitaker Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sentry_sdk/integrations/celery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@

import sys

from celery.exceptions import SoftTimeLimitExceeded, Retry # type: ignore
from celery.exceptions import ( # type: ignore
SoftTimeLimitExceeded,
Retry,
Ignore,
Reject,
)

from sentry_sdk.hub import Hub
from sentry_sdk.utils import capture_internal_exceptions, event_from_exception
Expand All @@ -11,6 +16,9 @@
from sentry_sdk.integrations.logging import ignore_logger


CELERY_CONTROL_FLOW_EXCEPTIONS = (Retry, Ignore, Reject)


class CeleryIntegration(Integration):
identifier = "celery"

Expand Down Expand Up @@ -106,7 +114,7 @@ def _capture_exception(task, exc_info):

if hub.get_integration(CeleryIntegration) is None:
return
if isinstance(exc_info[1], Retry):
if isinstance(exc_info[1], CELERY_CONTROL_FLOW_EXCEPTIONS):
return
if hasattr(task, "throws") and isinstance(exc_info[1], task.throws):
return
Expand Down