Skip to content

Fix redis pipeline commands #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix redis pipeline commands #3631

merged 1 commit into from
Oct 8, 2024

Conversation

antonpirker
Copy link
Member

Otel span.set_attribute() does not allow dict values, thus we change the data to be compatible

@antonpirker antonpirker self-assigned this Oct 8, 2024
@antonpirker antonpirker requested a review from sentrivana October 8, 2024 12:55
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

❌ 2928 Tests Failed:

Tests completed Failed Passed Skipped
17781 2928 14853 1727
View the top 3 failed tests by shortest run time 
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker antonpirker merged commit 4b2b6db into potel-base Oct 8, 2024
15 of 120 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/fix-redis-pipeline-commands branch October 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

@antonpirker antonpirker

Labels
Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana