Skip to content

Implement span limits on span processor #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sl0thentr0py
Copy link
Member

These limits are slightly different than before because they hold on each level of the span tree rather than on the whole transaction but I think that's fine since the main purpose of these limits are avoiding unbounded memory blowup.

Copy link

codecov bot commented Dec 18, 2024

❌ 277 Tests Failed:

Tests completed Failed Passed Skipped
14710 277 14433 3614
View the top 3 failed tests by shortest run time
 tests.integrations.celery.integration_tests.test_celery_beat_cron_monitoring
Stack Traces | 0s run time
No failure message available
 tests.integrations.celery.test_celery_beat_crons
Stack Traces | 0s run time
No failure message available
 tests.integrations.celery.test_update_celery_task_headers
Stack Traces | 0s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@sl0thentr0py sl0thentr0py merged commit 858cacd into potel-base Dec 18, 2024
102 of 123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/implement-span-maxlen branch December 18, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants