Skip to content

Deprecate set_measurement() API. #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 29, 2025
Merged

Deprecate set_measurement() API. #3934

merged 11 commits into from
Apr 29, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jan 14, 2025 •
edited
Loading

Deprecate set_measurement(). This will be replaced by set_data() which internally is using the Otel set_attribute().

Fixes #3074

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.26%. Comparing base (c6db420) to head (fa9e9b7).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3934      +/-   ##
==========================================
- Coverage   80.33%   80.26%   -0.07%     
==========================================
  Files         142      142              
  Lines       15933    15935       +2     
  Branches     2725     2725              
==========================================
- Hits        12800    12791       -9     
- Misses       2261     2268       +7     
- Partials      872      876       +4
Files with missing lines Coverage Δ
sentry_sdk/api.py 79.85% <ø> (ø)
sentry_sdk/tracing.py 78.57% <100.00%> (-0.32%) ⬇️

... and 3 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review January 14, 2025 14:44
@antonpirker
Copy link
Member Author

antonpirker commented Jan 14, 2025 •
edited
Loading

As this is kind of in sleep-mode right now, we keep this PR open but will not merge it right now.

See: https://github.com/getsentry/projects/issues/73

@antonpirker antonpirker removed the request for review from sentrivana January 14, 2025 15:19
@antonpirker antonpirker marked this pull request as draft January 14, 2025 15:21
@antonpirker
Copy link
Member Author

Picking this up again, Daniel G said we should deprecated now and remove in 3.0.

@antonpirker antonpirker self-assigned this Apr 29, 2025
@antonpirker antonpirker marked this pull request as ready for review April 29, 2025 09:40
@antonpirker antonpirker requested a review from a team as a code owner April 29, 2025 09:40
@antonpirker antonpirker merged commit 28a87df into master Apr 29, 2025
141 checks passed
@antonpirker antonpirker deleted the antonpirker/deprecate-set-measurement branch April 29, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate set_measurement API
2 participants
@antonpirker @sentrivana