Skip to content

Make continuous profiler work in POtel span_processor #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2025
Merged

Make continuous profiler work in POtel span_processor #4098

merged 4 commits into from
Mar 31, 2025

Conversation

antonpirker
Copy link
Member

Fixes #4063

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

❌ 93 Tests Failed:

Tests completed Failed Passed Skipped
20499 93 20406 4474
View the top 3 failed test(s) by shortest run time 
tests.profiler.test_continuous_profiler test_continuous_profiler_invalid_mode[experiment-foo]
Stack Traces | 0.001s run time 
tests/profiler/test_continuous_profiler.py:68: in test_continuous_profiler_invalid_mode
    with pytest.raises(ValueError):
E   Failed: DID NOT RAISE <class 'ValueError'>
tests.profiler.test_continuous_profiler test_continuous_profiler_invalid_mode[experiment-foo]
Stack Traces | 0.001s run time 
tests/profiler/test_continuous_profiler.py:68: in test_continuous_profiler_invalid_mode
    with pytest.raises(ValueError):
E   Failed: DID NOT RAISE <class 'ValueError'>
tests.profiler.test_continuous_profiler test_continuous_profiler_invalid_mode[experiment-foo]
Stack Traces | 0.001s run time 
tests/profiler/test_continuous_profiler.py:68: in test_continuous_profiler_invalid_mode
    with pytest.raises(ValueError):
E   Failed: DID NOT RAISE <class 'ValueError'>

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker requested a review from a team as a code owner March 26, 2025 11:40
@antonpirker antonpirker merged commit 9cf068b into potel-base Mar 31, 2025
105 of 128 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/continuous_profiling branch March 31, 2025 08:54
@antonpirker antonpirker mentioned this pull request Mar 31, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

@Zylphrex Zylphrex Awaiting requested review from Zylphrex

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana