Skip to content

feat: Sample everything 100% w/ Spotlight & no DSN set #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

feat: Sample everything 100% w/ Spotlight & no DSN set #4207

merged 4 commits into from
Mar 28, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Mar 27, 2025

This patch makes Spotlight easier to setup by turning all sampling to 100% when no DSN is set and Spotlight is enabled. I consider this a non-breaking and a safe change as these only apply when no DSN is set so it should have no production or billing implications.

@BYK
feat: Sample everything 100% w/ Spotlight & no DSN set
b4dec89 
This patch makes Spotlight easier to setup by turning all sampling to 100% when no DSN is set and Spotlight is enabled. I consider this a non-breaking and a safe change as these only apply when no DSN is set so it should have no production or billing implications.
@BYK BYK requested a review from a team as a code owner March 27, 2025 17:59
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
22323 1 22322 5593
View the top 1 failed test(s) by shortest run time 
tests.integrations.grpc.test_grpc_aio test_grpc_server_abort
Stack Traces | 0.096s run time 
.../integrations/grpc/test_grpc_aio.py:153: in test_grpc_server_abort
    assert len(events) == 1
E   assert 0 == 1
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

szokeasaurusrex
szokeasaurusrex approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have two suggestions, but since you'll likely have to implement them anyways in order to get the tests to pass, I'll approve

szokeasaurusrex
szokeasaurusrex approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see suggestion

@szokeasaurusrex
Copy link
Member

I'm not quite sure why the GraphQL tests are failing here

@szokeasaurusrex
Copy link
Member

Ah @sentrivana just pointed out in Slack that graphql tests are failing on master, so it might not be caused by this PR

BYK and others added 2 commits March 28, 2025 10:48
@BYK @szokeasaurusrex
Add *kwargs too, just in case
cde3cfc 
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
@BYK
Merge branch 'master' into byk/feat/enable-all-sampling-with-spotlight
4e2f6b3
@BYK BYK merged commit 3b28649 into master Mar 28, 2025
138 of 139 checks passed
@BYK BYK deleted the byk/feat/enable-all-sampling-with-spotlight branch March 28, 2025 11:05
@BYK BYK mentioned this pull request Mar 28, 2025
Closed
@rassie rassie mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BYK @szokeasaurusrex @sentrivana