Fixed some tests #4217
Merged
Fixed some tests #4217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_profiling_mode does not exist anymore
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4217 +/- ##
==============================================
- Coverage 83.56% 83.54% -0.02%
==============================================
Files 143 143
Lines 14630 14630
Branches 2317 2317
==============================================
- Hits 12225 12223 -2
Misses 1689 1689
- Partials 716 718 +2 |
|
@sentrivana this PR makes the last three tests green. :-) |
szokeasaurusrex
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
profiles_sample_rateis not experimental anymorecontinuous_profiling_modehas been removed so only the top levelprofiler_modeexists. (so the if is not necessary anymore)