fix: Better memory usage for tracing #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @HazAT and @kamilogorek just so they've seen the memory issues with long-running transactions once... |
|
@untitaker I tried the same trace as in #430 and Sentry is not in the top 20 (or 50 for that matter). So, yes, it does fix the problem described in #430. |
This reverts commit 897b683.
kamilogorek
approved these changes
Jul 15, 2019
|
Trimming has been removed again because we do not know what to do with trimmed data. Instead the only change here is that un-sampled transactions don't build a list of spans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #430
@reupen could you try this one out? I assume it will fix your problem but maybe your issue with 0.10 is something entirely else