Skip to content

feat: Make client pickleable #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2019
Merged

feat: Make client pickleable #439

merged 4 commits into from
Aug 7, 2019

Conversation

untitaker
Copy link
Member

No description provided.

@tiopi
Copy link
Contributor

tiopi commented Jul 31, 2019

Should the client ensure that attributes like server_name and user are set correctly when an exception is caught or is that based on when the exception is captured?

@tiopi tiopi mentioned this pull request Aug 1, 2019
@untitaker
Copy link
Member Author

@tiopi what do you mean?

@tiopi
Copy link
Contributor

tiopi commented Aug 5, 2019

@tiopi what do you mean?

https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/client.py#L57L65 this code gets referenced only when the client is init. However, if I send the client off to another machine, some of those values are not reset by the time an error happens. I was wondering if updating the values was part of the client getting binded with a hub (on a worker in this case), or if it had to be done manually when an event is sent over.

@untitaker
Copy link
Member Author

@tiopi let's postpone this issue and merge this as-is. If people care about this data I guess they have to re-set it explicitly.

@untitaker untitaker merged commit b7e32c5 into master Aug 7, 2019
@untitaker untitaker deleted the feat/pickle-client branch August 7, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants