fix: Fix a bunch of bugs in subprocess integration #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Aug 5, 2019
| @@ -123,14 +127,18 @@ def _init_argument(args, kwargs, name, position, setdefault_callback=None): | |||
|
|
|||
| if name in kwargs: | |||
| rv = kwargs[name] | |||
| if rv is None and setdefault_callback is not None: | |||
| rv = kwargs[name] = setdefault_callback() | |||
| if setdefault_callback is not None: | |||
There was a problem hiding this comment.
I’m probably lacking context, but shouldn’t this also retain the check for None?
There was a problem hiding this comment.
Checking what for None?
There was a problem hiding this comment.
Oh wait, just realizing that you’re now passing rv into that callback.
jan-auer
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing args and kwargs like that seems like a rabbit hole, but there's no other way to instrument this that I am aware of.
Fix #436.