Skip to content

Change Lambda timeout warning message #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 5, 2025

The timeout in the AWS Lambda (and GCP, by extension) timeout warning is wrong, remove it and slightly rephrase.

This is on potel-base since it breaks grouping. (Even just removing the number from the original message, without modifying it further, causes regrouping. Since that's the case I took the liberty to update the message a bit more.)

Fixes #4629

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.98%. Comparing base (c27ac1f) to head (47d6b01).
⚠️ Report is 13 commits behind head on potel-base.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4671      +/-   ##
==============================================
+ Coverage       83.75%   84.98%   +1.22%     
==============================================
  Files             158      158              
  Lines           15517    15517              
  Branches         2456     2456              
==============================================
+ Hits            12997    13187     +190     
+ Misses           1765     1574     -191     
- Partials          755      756       +1     
Files with missing lines Coverage Δ
sentry_sdk/utils.py 88.59% <0.00%> (+1.30%) ⬆️

... and 10 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review August 5, 2025 07:41
@sentrivana sentrivana requested a review from a team as a code owner August 5, 2025 07:41
@sentrivana sentrivana merged commit e8ded65 into potel-base Aug 12, 2025
124 of 125 checks passed
@sentrivana sentrivana deleted the ivana/fix-aws-lambda-message branch August 12, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants