Skip to content

improvement: add celery task_id into tags #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

improvement: add celery task_id into tags #596

merged 1 commit into from
Feb 10, 2020

Conversation

lemonlatte
Copy link
Contributor

Reference to issue: #552

The task id is very useful for debugging celery tasks. I add it by using set_tag.

@lemonlatte lemonlatte requested a review from untitaker January 22, 2020 03:07
untitaker
untitaker approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds OK, but can you rename this to celery_task_id and move this inside the event processor where extra is set?

untitaker
untitaker requested changes Jan 22, 2020
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see prev accidental approval

@lemonlatte
Copy link
Contributor Author

@untitaker I just update and push again. The check failed at the documentation process. I found it failed from the previous commit. My change is affect because I rebase onto the master branch.

@lemonlatte lemonlatte requested a review from untitaker February 10, 2020 06:03
@untitaker
Copy link
Member

Thanks!

@untitaker untitaker merged commit ca3c6b5 into getsentry:master Feb 10, 2020
@lemonlatte lemonlatte deleted the add-task-id-in-tags branch February 10, 2020 08:34
@thomas-riccardi thomas-riccardi mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemonlatte @untitaker