feat: add cloudwatch logs URL to lambda additional data #618
Conversation
| """ | ||
| start_time_str = (start_time - timedelta(seconds=1)).isoformat().split(".")[0] | ||
| end_time_str = (datetime.now() + timedelta(seconds=2)).isoformat().split(".")[0] | ||
| url = ''.join([ |
There was a problem hiding this comment.
Instead of this please do
url = (
"string 1"
"string 2"
)
There was a problem hiding this comment.
That syntax will only work with quoted strings, half of these are variables/functions. I can do a multiline string with .format at the end, is that what you want?
There was a problem hiding this comment.
yeah sorry I didn't even think about that. .format is good
| Returns: | ||
| str -- AWS Console URL to logs. | ||
| """ | ||
| start_time_str = (start_time - timedelta(seconds=1)).isoformat().split(".")[0] |
There was a problem hiding this comment.
would prefer a strftime with explicit args here
There was a problem hiding this comment.
Ok, why? Happy to do it, just curious. could also do this:
.replace(microsecond=0).isoformat() if you object to the .split('.')[0]
|
oh yeah please also add tests for this and ensure linting passes |
4ace295 to
a1f2ed2
Compare
|
Awesome, thanks! |
|
Oh, uh... sorry, wasn't done. I just pushed up the tests. |
|
Damn, sorry. Could you PR those separately? |
As discussed on discord, this adds an additional "extra" for cloudwatch logs URL, log group, and log stream.
Not sure what if any tests are required for this change. Thoughts?