Skip to content

feat(transport): Remove absolute time stamps #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

feat(transport): Remove absolute time stamps #651

merged 1 commit into from
Mar 19, 2020

Conversation

mitsuhiko
Copy link
Contributor

The quota system no longer supports absolute timestamps.

@mitsuhiko mitsuhiko requested a review from jan-auer March 19, 2020 14:03
jan-auer
jan-auer approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to trim limit in case the headers are separated with ", "?

@mitsuhiko mitsuhiko merged commit 28549cf into master Mar 19, 2020
@mitsuhiko mitsuhiko deleted the feature/drop-absolute-times branch March 19, 2020 14:30
@mitsuhiko
Copy link
Contributor Author

Limit already gets trimmed.

@jan-auer jan-auer mentioned this pull request Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitsuhiko @jan-auer