-
Notifications
You must be signed in to change notification settings - Fork 544
feat(redis): Patch rediscluster if present #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Jun 30, 2020
tonyo
reviewed
Jun 30, 2020
tonyo
reviewed
Jun 30, 2020
619a95a
to
e4c36e2
Compare
tonyo
approved these changes
Jun 30, 2020
untitaker
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm aside from linter failures. make format lint
should do the trick locally
747561d
to
46c6b75
Compare
In addition to the redis and rb clients try to patch also the rediscluster library which does not use the already patched clients.
untitaker
reviewed
Jul 1, 2020
untitaker
reviewed
Jul 1, 2020
1ddd641
to
0058c31
Compare
untitaker
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the redis and rb clients try to patch also the rediscluster library which does not use the already patched clients.