feat: Integration for Chalice #779
Conversation
sentry_sdk/integrations/chalice.py
Outdated
| reraise(*exc_info) | ||
|
|
||
|
|
||
| old_get_view_function_response = Chalice._get_view_function_response |
There was a problem hiding this comment.
Please don't have a global backup of the view function response, this will break if multiple libraries monkeypatch chalice
There was a problem hiding this comment.
add this in setup_once().
There was a problem hiding this comment.
Regarding the tests, these fail because the parameters of the context '_max_runtime' arrive null, so this line
is not executed, the response if it contains the status_code '500' and the json, I don't understand why it fails in travis.|
@untitaker you now have permissions to push to our fork. We're already using |
|
fwiw, Chalice does have a stub file for type hinting, It shouldn't be necessary to ignore the import to resolve this error: https://travis-ci.com/github/getsentry/sentry-python/jobs/382832642#L249-L251 |
|
Yes but we can't install all optional dependencies at once when type
checking. Also we should not rely on those stubs as they are wrong (eg
flask, celery) or change between versions.
Technically we would have to typecheck for each entry in the cross product
of all versions of frameworks we support.
…On Wed, Sep 9, 2020 at 8:24 PM Matin Tamizi ***@***.***> wrote:
fwiw, Chalice *does* have a stub file for type hinting, app.pyi
<https://github.com/aws/chalice/blob/master/chalice/app.pyi>, and
includes py.typed
<https://github.com/aws/chalice/blob/master/chalice/py.typed>.
It shouldn't be necessary to ignore the import to resolve this error:
https://travis-ci.com/github/getsentry/sentry-python/jobs/382832642#L249-L251
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#779 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGMPRPE25BU3WHBK476NGLSE7B7JANCNFSM4P2ODGZA>
.
|
This is a proposal for the integration of Chalice in Sentry