Skip to content

Travis CI: Test on Python 3.9 release candidate 1 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 2, 2020

Xenial is already the default dist on Travis CI. (bionic and focal are also available)

Py39 in allow_failures mode until the GA release in one month. https://devguide.python.org/#status-of-python-branches

Note: Python 3.4 is end of life and 3.5 will be end of life in two weeks. https://devguide.python.org/devcycle/#end-of-life-branches

Also fixes:
Screenshot 2020-09-02 at 11 59 43

Xenial is already the default dist on Travis CI.  (bionic and focal are also available)

In allow_failures mode until the GA release in one month.  https://devguide.python.org/#status-of-python-branches

Note: Python 3.4 is end of life and 3.5 will be end of life in two weeks.  https://devguide.python.org/devcycle/#end-of-life-branches

Fixes:
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, can you add py3.9 to tox.ini as well? There are potentially a few other jobs that would benefit from this.

@untitaker
Copy link
Member

untitaker commented Sep 2, 2020

here's a commit that added python 3.8: 9dc161b#diff-b91f3d5bd63fcd17221b267e851608e8

I am not sure if all the web frameworks we integrate with will run on Python 3.9 so it's probably too soon to add 3.9 to all of them

EDIT: Ah well you went for it, let's see

@untitaker
Copy link
Member

Note: Python 3.4 is end of life and 3.5 will be end of life in two weeks.

You will be shocked to learn we support Python 2 :D

@cclauss
Copy link
Contributor Author

cclauss commented Sep 2, 2020

Typos...
$ codespell . --ignore-words-list=ba,iam,referer,upto --skip=./.* --quiet-level=2

./CHANGES.md:205: Thansk ==> Thanks
./sentry_sdk/transport.py:375: instanciate ==> instantiate
./sentry_sdk/integrations/rq.py:42: Unparseable ==> Unparsable
./sentry_sdk/integrations/falcon.py:107: Unparseable ==> Unparsable
./sentry_sdk/integrations/sqlalchemy.py:34: Unparseable ==> Unparsable
./sentry_sdk/integrations/aiohttp.py:57: unparseable ==> unparsable
./sentry_sdk/integrations/sanic.py:49: Unparseable ==> Unparsable
./sentry_sdk/integrations/bottle.py:62: Unparseable ==> Unparsable
./sentry_sdk/integrations/redis.py:59: occured ==> occurred
./sentry_sdk/integrations/flask.py:70: Unparseable ==> Unparsable

@untitaker
Copy link
Member

Thanks I fixed the typos on master

@cclauss
Copy link
Contributor Author

cclauss commented Sep 2, 2020

Why test on pypy (Python 2.7) but not test on pypy3 (Python 3.6)?

@untitaker
Copy link
Member

iirc Travis pypy3 used to be broken at some point and our usage stats didn't warrant extra effort.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 2, 2020

Pretty remarkable that celery is the only py39 TODO!

@untitaker untitaker merged commit 4aecbfd into getsentry:master Sep 2, 2020
@untitaker
Copy link
Member

Excellent, thanks!

@cclauss cclauss deleted the patch-1 branch September 2, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants