Skip to content

fix: Allow ASGI middleware to capture exceptions in nested call #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2020
Merged

fix: Allow ASGI middleware to capture exceptions in nested call #817

merged 3 commits into from
Sep 14, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Sep 9, 2020 •
edited
Loading

When the exception bubbles up we deduplicate it based on object identity, so this should be fine

Fix #816

@untitaker untitaker mentioned this pull request Sep 9, 2020
Closed
@untitaker untitaker merged commit ce83b95 into master Sep 14, 2020
@untitaker untitaker deleted the fix/asgi-middleware-recursive-exceptions branch September 14, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

last_event_id() returns None after SentryAsgiMiddleware.__call__() finished
1 participant
@untitaker