Skip to content

fix(django): Fix complex either url patterns in Django #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

fix(django): Fix complex either url patterns in Django #875

merged 1 commit into from
Oct 19, 2020

Conversation

ChillarAnand
Copy link
Contributor

@ChillarAnand ChillarAnand commented Oct 17, 2020 •
edited
Loading

Resolves #874

@untitaker
Copy link
Member

Thanks, I think we actually need some matching that cannot be expressed by regex, i.e. actually match open/closing parens, but I think this is good enough.

Can you rebase to fix CI?

@untitaker untitaker merged commit c752e9f into getsentry:master Oct 19, 2020
@untitaker
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of complex urls in django
2 participants
@ChillarAnand @untitaker