convert : fix nomic-bert-moe mask token #13757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also correct obvious vocab padding error (most likely no actual change for any model out there, but at least makes sense now)
|
@slaren gentle ping |
|
Sorry, I don't know this code enough to review it. |
Ok, maybe @compilade can take a look now after a well deserved post-NorthSec break. :) |
|
@compilade gentle ping |
compilade
reviewed
Jun 1, 2025
compilade
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing UGM tokenizer with
nomic-embed-text-v2-moeI noticed that the mask token was not set correctly. This fixes conversion and sets thelstriptoken attribute at runtime.cc/ @cebtenzzre