mtmd : move helpers to dedicated library (⚠️ breaking change) #13866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
May 28, 2025
|
@ggerganov yes most of the changes are just moving the code around. There could be leftover/redundant things (spotted one on 669fe81), but they won't affect the functionality. I will continue clean things up with my upcoming PRs |
|
I still see Line 91 in e562eec |
|
A lot of things in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First breaking change in
libmtmd:mtmd_helpers_*are moved to a dedicated library. If you use the shared library, make sure to link against the newlibmtmd_helper_sharedwithmtmd-helper.hheadermtmd_helper_bitmap_init_from_*now takesmtmd_context * ctxas the first argument. This is needed to determine the audio bitrateWhy this change is needed?
mtmd-helperis not part of the main library. As the name suggested, it provides a higher-level functions that allow developer to get started withlibmtmdmore easily. Making it a dedicated library to clarify this ideaminiaudio.handstb_image.hare 2 large single-header dependencies, which can increase compilation time of the mainlibmtmd. By moving them tomtmd-helper, we reduce this compilation time during the development (QoL improvement for contributors)