parallel : increase the variability of the prompt lengths #13927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compilade
reviewed
May 31, 2025
| @@ -315,7 +315,10 @@ int main(int argc, char ** argv) { | |||
| } else { | |||
| client.prompt += k_system; | |||
| } | |||
| for (int i = 0; i < n_junk; ++i) { | |||
|
|
|||
| const int n_junk_cur = rand() % n_junk; | |||
There was a problem hiding this comment.
When n_junk is zero this is a division by zero.
Suggested change
| const int n_junk_cur = rand() % n_junk; | |
| const int n_junk_cur = n_junk > 0 ? rand() % n_junk : 0; |
Since n_junk = 0 is the default, this throws a floating point exception by default.
llama.cpp/examples/parallel/parallel.cpp
Line 161 in bc6e86b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the prompts have randomly between
[0, n_junk)dummy questions before the actual question.