-
Notifications
You must be signed in to change notification settings - Fork 12k
ggml: check if non-native endian model is being loaded #13943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ggml: check if non-native endian model is being loaded #13943
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
@JohannesGaessler applied your suggested changes. I've moved the PTAL again. P.S., Edit: Also re-tested the new changes on ARM64 and s390x. Both worked as intended. |
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say with this error message it's fine to remove the assert again but either way is fine I think.
Unfortunately that
while the endianness check did not; as expected. If the CI passes, feel free to merge it into |
This PR adds more descriptive error messages for when a non-native endian model is being loaded on the host system.
Verification
To ensure that this implementation did not break anything, this PR has been tested on the following systems: