ggml : prevent integer overflow in tensor size calculation #14595
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 9, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 9, 2025
slaren
approved these changes
Jul 9, 2025
gabe-l-hart
added a commit
to gabe-l-hart/llama.cpp
that referenced
this pull request
Jul 9, 2025
* origin/master: ggml : prevent integer overflow in gguf tensor size calculation (ggml-org#14595) model : add skt/A.X-4.0 model vocabulary (ggml-org#14589) llama : remove unintended whitespace (ggml-org#14592) model : add support for Falcon-H1 family (ggml-org#14534) convert : fix smollm3 jinja template (ggml-org#14586)
ryan-mangeno
pushed a commit
to ryan-mangeno/llama.cpp
that referenced
this pull request
Jul 9, 2025
…-org#14595) Signed-off-by: ryan-mangeno <ryanmangeno@gmail.com>
qnixsynapse
pushed a commit
to menloresearch/llama.cpp
that referenced
this pull request
Jul 10, 2025
qnixsynapse
pushed a commit
to menloresearch/llama.cpp
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to prevent integer overflow when accumulating tensor sizes in gguf_init_from_file_impl.
This avoids potential oob read/write from malformed GGUF files.